Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure built-in logging #79

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kov117
Copy link
Contributor

@kov117 kov117 commented Nov 21, 2024

Checklist

  • I've updated both the azurerm_linux_function_app and azurerm_windows_function_app resources.

@kov117 kov117 added the enhancement New feature or request label Nov 21, 2024
@kov117 kov117 self-assigned this Nov 21, 2024
@kov117
Copy link
Contributor Author

kov117 commented Nov 21, 2024

Test passed 🎆

@kov117 kov117 marked this pull request as ready for review November 21, 2024 13:24
@kov117 kov117 requested a review from a team as a code owner November 21, 2024 13:24
@hknutsen hknutsen changed the title feat: configur a built in logging feat: configure built-in logging Nov 21, 2024
@hknutsen
Copy link
Member

hknutsen commented Nov 21, 2024

It's recommended for built-in logging to be disabled by default: https://learn.microsoft.com/en-us/azure/azure-functions/configure-monitoring?tabs=v2#disable-built-in-logging

@kov117
Copy link
Contributor Author

kov117 commented Nov 21, 2024

will change the configuration to disabled 🫡

@hknutsen
Copy link
Member

It's recommended for built-in logging to be disabled by default: https://learn.microsoft.com/en-us/azure/azure-functions/configure-monitoring?tabs=v2#disable-built-in-logging

Could even consider hard-coding it to be disabled, and recommend using App Insights instead. A variable for enabling built-in logging can always be added at a later date if absolutely needed.

@kov117
Copy link
Contributor Author

kov117 commented Nov 22, 2024

i don't see a problem with that, if the rest of the team @equinor/terraform-baseline-maintainers agree then i will implement the suggested change 👍🏼

@kov117
Copy link
Contributor Author

kov117 commented Nov 22, 2024

Ran a new test and it passed 👍🏼

@hknutsen
Copy link
Member

It's recommended for built-in logging to be disabled by default: https://learn.microsoft.com/en-us/azure/azure-functions/configure-monitoring?tabs=v2#disable-built-in-logging

Could even consider hard-coding it to be disabled, and recommend using App Insights instead. A variable for enabling built-in logging can always be added at a later date if absolutely needed.

Waiting for feedback from @equinor/terraform-baseline-maintainers.

@hknutsen
Copy link
Member

@kov117 Hardcode built-in logging to be disabled for now, and update tests accordingly. We can always add a variable later if absolutely necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants