-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure built-in logging #79
base: main
Are you sure you want to change the base?
Conversation
Test passed 🎆 |
It's recommended for built-in logging to be disabled by default: https://learn.microsoft.com/en-us/azure/azure-functions/configure-monitoring?tabs=v2#disable-built-in-logging |
will change the configuration to disabled 🫡 |
Could even consider hard-coding it to be disabled, and recommend using App Insights instead. A variable for enabling built-in logging can always be added at a later date if absolutely needed. |
i don't see a problem with that, if the rest of the team @equinor/terraform-baseline-maintainers agree then i will implement the suggested change 👍🏼 |
Ran a new test and it passed 👍🏼 |
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Waiting for feedback from @equinor/terraform-baseline-maintainers. |
@kov117 Hardcode built-in logging to be disabled for now, and update tests accordingly. We can always add a variable later if absolutely necessary. |
Checklist
azurerm_linux_function_app
andazurerm_windows_function_app
resources.