Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bookmarks): resolve request method issue and improve response handling #2650

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Dec 11, 2024

Why

Fixed isBookmarkInFavorites by altering generateRequestParameters which had a copy paste bug (wrong request method). Also disabled the validate_api_request response operation for now, it was throwing an error on all response code which waas not OK.

in a future update, the ResponseHandler will provide the operators with the Request object, so they can access the request method and other request properties.

Also fixed the headSelector to only check response code, since a HEAD request does not return a body.

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 6fe5df7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@equinor/fusion-framework-module-services Patch
@equinor/fusion-framework Patch
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework-react-widget Patch
@equinor/fusion-framework-widget Patch
poc-portal Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-react-module-bookmark Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 🧬 Modules labels Dec 11, 2024
@odinr odinr force-pushed the fix/module/services/check-user-bookmark-favourite branch from bb41704 to 6fe5df7 Compare December 11, 2024 11:40
@odinr odinr self-assigned this Dec 11, 2024
@odinr odinr requested a review from asbjornhaland December 11, 2024 11:48
@odinr odinr marked this pull request as ready for review December 11, 2024 11:48
@odinr odinr requested a review from a team as a code owner December 11, 2024 11:48
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.37% 1746 / 464422
🔵 Statements 0.37% 1746 / 464422
🔵 Functions 22.93% 205 / 894
🔵 Branches 36.93% 386 / 1045
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/modules/services/src/provider.ts 0% 0% 0% 0% 1-116
packages/modules/services/src/bookmarks/selectors.ts 0% 0% 0% 0% 1-46
packages/modules/services/src/bookmarks/endpoints/user-bookmark-favourite.head.ts 0% 0% 0% 0% 1-105
Generated in workflow #8197 for commit 6fe5df7 by the Vitest Coverage Report Action

@odinr odinr merged commit 2343667 into main Dec 11, 2024
10 checks passed
@odinr odinr deleted the fix/module/services/check-user-bookmark-favourite branch December 11, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🧬 Modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants