Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 Add api version to remove warnings #1909 #2012

Merged
merged 2 commits into from
Dec 15, 2023
Merged

🚨 Add api version to remove warnings #1909 #2012

merged 2 commits into from
Dec 15, 2023

Conversation

padms
Copy link
Contributor

@padms padms commented Dec 5, 2023

No description provided.

@padms padms requested a review from a team as a code owner December 5, 2023 13:54
millianapia
millianapia approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@millianapia millianapia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but is it possible to apply the api version on all of the files in one place?

@fernandolucchesi
Copy link
Contributor

Looks good, but is it possible to apply the api version on all of the files in one place?

Agree with @millianapia, if not possible we should define a constant for that. Also noticed that in sanity.client.ts we use apiVersion: '2023-01-01' without the letter V on the beginning: `v 2023-01-01'. Could that be the reason why we get all these warnings?

@padms
Copy link
Contributor Author

padms commented Dec 6, 2023

Agreed and refactored .. :)

millianapia
millianapia approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@millianapia millianapia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! great work

@padms padms merged commit b58c779 into main Dec 15, 2023
4 checks passed
@millianapia millianapia deleted the padms/1909 branch February 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millianapia millianapia millianapia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padms @fernandolucchesi @millianapia