Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RocksDB-backed Merkle Tree #6
Introduce RocksDB-backed Merkle Tree #6
Changes from all commits
b7b5db6
6dd4e06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just write it ~as is? i.e.
<num values: 32bit unsigned>,<value0>, <value1>, <value2>...
- all numbers big endian encoded?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fully sure of what you want, would it still be a
Vec
, containing the length as the first element and the rest of the values (keys) in their non-parsed variant?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry I expressed myself a bit poorly. I basically responded to your
FIXME
comment question from above. No need to change anything here, but my thinking was that one possibility for persistent storage solution here would be to just write the values out to file, prefixing them by number of elements.No need to do anything here 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these endianness conversions work correctly on all platforms? i.e. is
derived_key
little-endian even on big-endian platform?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume so, though I can't guarantee. Do you have an idea on how to assert this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe checking the
LogQuery
implementation is one way? I'm not sure if this is a big concern right now, since there are very little big endian platforms alive anymore, and probably none of them will run this code, but I got curious since there's both endianness conversion / assumption in our code base. 🙂