feat: initial export snapshot skeleton #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuommaki
approved these changes
Nov 9, 2023
src/processor/snapshot/mod.rs
Outdated
| impl Processor for SnapshotExporter { | ||
| async fn run(mut self, mut rx: mpsc::Receiver<CommitBlockInfoV1>) { | ||
| // TODO: Send these from fetcher. | ||
| let miniblock_number = U64::from(0); |
There was a problem hiding this comment.
Suggested change
| let miniblock_number = U64::from(0); |
This will be sort of "WONTFIX", because we don't have any information about miniblocks. AFAIU miniblocks are the L2 transaction bundles and those aren't stored in L1. Only the resulting state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a skeleton of the export snapshot functionality.
Currently only handles the partial exporting of storage logs. Storage logs processing are missing handling of
enumeration_index&L1Metadatathat needs to be procured through the fetcher.