Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile #35

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add Dockerfile #35

merged 2 commits into from
Oct 24, 2023

Conversation

tuommaki
Copy link
Collaborator

No description provided.

@tuommaki tuommaki requested a review from zeapoz October 24, 2023 06:00
@tuommaki tuommaki self-assigned this Oct 24, 2023
zeapoz
zeapoz approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@zeapoz zeapoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an accompanying section to the readme too? Otherwise, LGTM, not very familiar with Docker syntax though 😄

Dockerfile Show resolved Hide resolved
tuommaki
tuommaki commented Oct 24, 2023
View reviewed changes
Copy link
Collaborator Author

@tuommaki tuommaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an accompanying section to the readme too?

Sure, I'll put a section about podman. Whoever uses OS X needs to figure on their own. I don't own such machine 🤷‍♂️

Dockerfile Show resolved Hide resolved
@tuommaki tuommaki merged commit a2356ec into main Oct 24, 2023
4 checks passed
@tuommaki tuommaki deleted the add-dockerfile branch October 24, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeapoz zeapoz zeapoz approved these changes

Assignees

@tuommaki tuommaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuommaki @zeapoz