Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unnecessary use of Arc wrapping #10

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Drop unnecessary use of Arc wrapping #10

merged 1 commit into from
Oct 4, 2023

Conversation

tuommaki
Copy link
Collaborator

@tuommaki tuommaki commented Oct 4, 2023

After further discussion & experimentation, it turns out that Arc was indeed unnecessary.

So let's get rid of it for now 😛

@tuommaki tuommaki requested a review from zeapoz October 4, 2023 10:30
@tuommaki tuommaki self-assigned this Oct 4, 2023
zeapoz
zeapoz approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@zeapoz zeapoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tuommaki tuommaki merged commit f21c95e into main Oct 4, 2023
4 checks passed
@tuommaki tuommaki deleted the drop-unnecessary-arc-wrap branch October 4, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeapoz zeapoz zeapoz approved these changes

Assignees

@tuommaki tuommaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuommaki @zeapoz