-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
179: make D real #180
179: make D real #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch I think a future feature/issue should be to make d, pwindow, and d_upper real as well and check this is supported as this could in theory be something someone might want to do
Can you please add a news item and if not done in the other PR add yourself as a contributor
I think ideally this would have a test to avoid it happening in the future. If you feel like it could you add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice LGTM. I used fewer cores and chains in the tests and made the news update a bit more specific.
Description
This PR closes #179 by defining D as real allowing it to be Inf.
[Describe the changes that you made in this pull request.]
Checklist