Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

179: make D real #180

Merged
merged 7 commits into from
Dec 11, 2024
Merged

179: make D real #180

merged 7 commits into from
Dec 11, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Dec 10, 2024

Description

This PR closes #179 by defining D as real allowing it to be Inf.

[Describe the changes that you made in this pull request.]

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch I think a future feature/issue should be to make d, pwindow, and d_upper real as well and check this is supported as this could in theory be something someone might want to do

Can you please add a news item and if not done in the other PR add yourself as a contributor

I think ideally this would have a test to avoid it happening in the future. If you feel like it could you add?

@seabbs seabbs enabled auto-merge (squash) December 11, 2024 13:35
NEWS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM. I used fewer cores and chains in the tests and made the news update a bit more specific.

@seabbs seabbs disabled auto-merge December 11, 2024 13:38
@seabbs seabbs merged commit aaf95ef into epinowcast:main Dec 11, 2024
5 of 12 checks passed
@sbfnk sbfnk deleted the fix-inf branch December 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set D to Inf
2 participants