Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 94: Add R and Stan for analytical Weibull #109

Merged
merged 24 commits into from
Oct 9, 2024
Merged

Issue 94: Add R and Stan for analytical Weibull #109

merged 24 commits into from
Oct 9, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Sep 27, 2024

Description

This PR closes #94 and adds:

  • Translation of the analytical Weibull with uniform solution to R and stan
  • Monte Carlo testing of the R analytical solution
  • Equivalence testing of the stan and R implementations

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs marked this pull request as ready for review October 8, 2024 17:58
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (b84867c) to head (60a2960).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   99.35%   99.80%   +0.45%     
==========================================
  Files          10       10              
  Lines         463      510      +47     
==========================================
+ Hits          460      509      +49     
+ Misses          3        1       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs requested a review from SamuelBrand1 October 9, 2024 12:15
@seabbs seabbs enabled auto-merge (squash) October 9, 2024 12:15
@seabbs
Copy link
Contributor Author

seabbs commented Oct 9, 2024

I think this is all working as expected now.

I need to do the following:

  • Open an issue to investigate the analytical solution in R failing when pwindow is large due to the lower incomplete gamma
  • Open an issue to investigate the sporadic NANs in the stan analytical solutions (all dists) when the cdf is 1.

Copy link
Contributor Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review). Checked with consistency between stan and R + numerical vs analytical in R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement analytical solution to Weibull with uniform
2 participants