address #6: allow custom messages #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisaloo
reviewed
Dec 18, 2023
DESCRIPTION
Outdated
| devtools | ||
| devtools, | ||
| cli, | ||
| rlang |
| @@ -69,7 +69,7 @@ coerceDT <- function( | |||
| if (is.character(data)) { | |||
| if (grepl(pattern = "\\.rds$", x = data, ignore.case = TRUE)) { | |||
| doargs$data <- setDT(readRDS( | |||
| tryCatch(normalizePath(data), warning = function(e) stop(e)) | |||
| tryCatch(normalizePath(data), warning = internal_error) | |||
There was a problem hiding this comment.
Is it intended that no args are passed to internall_error() here?
There was a problem hiding this comment.
yes - it's passing the functional handler.
R/zzz.R
Outdated
| if (requireNamespace("cli", quietly = TRUE)) { | ||
| packageStartupMessage("coerceDT: using `cli` messaging.") | ||
| } else { | ||
| packageStartupMessage("coerceDT: using `base` messaging; to use `cli` messages, install `cli`.") |
There was a problem hiding this comment.
Should it be documented somewhere that you'll need to reload this package after installing cli to get the improved conditions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will close #6 - may need to rebase after resolving the introduction of
defaultargs.This introduces load-if-available for
climessaging and will add arguments for custom messages / message templatesChecklist