Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-66 ♻️ 에러처리 로직 수정 #95

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

jangmoonwon
Copy link
Contributor

🔖 Issue Ticket

티켓 없음

✍️ Description

기존 400에러와 500에러를 한 번에 처리하는 로직 수정

  • 400 에러 처리:

    • 400 에러의 경우, data?.message를 확인하여 "이미 사용중인 이메일" 메시지를 포함하는 경우와 나머지 Bad Request에 대한 메시지 처리
  • 500 에러 처리:

    • 500 에러의 경우, data?.message를 확인하여 중복 닉네임인 경우와 나머지 500에러에 대한 메시지 처리와 그 외로 500번대 이상으로 올 수 있는 부분 따로 처리
  • 500 이상 에러 처리:

    • 서버 오류 메시지 표시

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • (없음)

@jangmoonwon jangmoonwon added Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링 labels Jul 28, 2024
@jangmoonwon jangmoonwon requested a review from a team July 28, 2024 18:30
@jangmoonwon jangmoonwon self-assigned this Jul 28, 2024
Copy link
Contributor

@JeonYumin94 JeonYumin94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good

수고하셨습니다!

@jangmoonwon jangmoonwon merged commit 3322aaa into epic/FE-66 Jul 28, 2024
1 check passed
@jangmoonwon jangmoonwon deleted the fix/FE-66 branch July 30, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants