Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE-81 ♻️ 마이페이지 프로필 수정 기능 리팩토링 #180

Merged
merged 3 commits into from
Aug 4, 2024
Merged

FE-81 ♻️ 마이페이지 프로필 수정 기능 리팩토링 #180

merged 3 commits into from
Aug 4, 2024

Conversation

JeonYumin94
Copy link
Contributor

🔖 Issue Ticket

Ticket

✍️ Description

  • 마이페이지 관련 파일들 폴더 이동
  • 프로필 수정 기능 관련 라이브러리 변경 (formik -> react-hook-form)
  • 닉네임 중복 체크 추가

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • (없음)

@JeonYumin94 JeonYumin94 added Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링 labels Aug 4, 2024
@JeonYumin94 JeonYumin94 requested a review from a team August 4, 2024 00:48
@JeonYumin94 JeonYumin94 self-assigned this Aug 4, 2024
jangmoonwon
jangmoonwon approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@jangmoonwon jangmoonwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Good
react-hook-form 잘 이용하셨네요! 수고하셨습니다 ㅎㅎ

@JeonYumin94 JeonYumin94 merged commit cbaedb4 into epic/FE-27--my-page Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jangmoonwon jangmoonwon jangmoonwon approved these changes

Assignees

@JeonYumin94 JeonYumin94

Labels
Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeonYumin94 @jangmoonwon