Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-58 ✨ 공용 컴포넌트 댓글 카드 구현 #17

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

newjinlee
Copy link
Contributor

🔖 Issue Ticket

Ticket

✍️ Description

image
공용 컴포넌트 댓글 카드를 구현했습니다.
반응형 디자인을 적용해 화면의 크기에 따라 카드의 크기가 변합니다.
props 값에 따라 댓글 카드를 수정 상태, 완료 상태로 변경할 수 있습니다.

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • (없음)

@newjinlee newjinlee added Priority: Medium 🔖 우선순위 보통 Type: Feature ✨ 신규 기능 labels Jul 11, 2024
@newjinlee newjinlee self-assigned this Jul 11, 2024
JeonYumin94
JeonYumin94 previously approved these changes Jul 11, 2024
Copy link
Contributor

@JeonYumin94 JeonYumin94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface types폴더에 따로 빼는거랑 styles 타입으로 빼는것도 좋아보입니다! 수고하셨습니다!

Copy link
Contributor

@JeonYumin94 JeonYumin94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@newjinlee newjinlee merged commit c374a27 into epic/FE-46-common-components Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium 🔖 우선순위 보통 Type: Feature ✨ 신규 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants