Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-83 ✨ 피드 페이지 구현 #165

Merged
merged 1 commit into from
Aug 3, 2024
Merged

FE-83 ✨ 피드 페이지 구현 #165

merged 1 commit into from
Aug 3, 2024

Conversation

newjinlee
Copy link
Contributor

  • FE-83 ✨ ui 구현 (sm 기준)

  • FE-83 ✨ grid/sort 구분 구현

  • FE-83 💄 더보기버튼 반응형 구현

  • FE-83 ✨ FAB 버튼 적용

  • FE-83 ✨ 에피그램 만들기 버튼 구현

🔖 Issue Ticket

Ticket

✍️ Description

피드 페이지 구현을 완료했습니다.
아이콘을 누르면 2n 배열에서 1n 배열로 변경됩니다.
FAB 버튼을 누르면 화면 맨 위로 스크롤 됩니다.
에피그램 만들기 버튼을 누르면 /addEpigram 페이지로 연결됩니다.
image
image
image

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • (없음)

* FE-83 ✨ ui 구현 (sm 기준)

* FE-83 ✨ grid/sort 구분 구현

* FE-83 💄 더보기버튼 반응형 구현

* FE-83 ✨ FAB 버튼 적용

* FE-83 ✨ 에피그램 만들기 버튼 구현
@newjinlee newjinlee added Priority: High 🔥 우선순위 높음 Type: Epic 🚀 큰 단위의 브랜치 labels Aug 2, 2024
@newjinlee newjinlee requested a review from a team August 2, 2024 06:46
@newjinlee newjinlee self-assigned this Aug 2, 2024
size='lg'
onClick={handleAddEpigramClick}
className='z-10 h-12 lg:h-16 px-3.5 lg:px-5 py-3 lg:py-4 bg-[#2c394d] text-white rounded-[100px] shadow-lg justify-center items-center gap-1 inline-flex fixed bottom-40 right-6 cursor-pointer'
role='button'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓Question
버튼 태그에 role='button' 속성을 넣으신 이유가 궁금합니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

처음엔 div였어서 넣었는데 button ui 사용하려고 button으로 바꿔서 남아있네요

Copy link
Contributor

@jisurk jisurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 고생하셨습니다

@newjinlee newjinlee merged commit 36be319 into main Aug 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High 🔥 우선순위 높음 Type: Epic 🚀 큰 단위의 브랜치
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants