Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-40 ✨ 내 댓글 수정 및 삭제 기능 #141

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

JeonYumin94
Copy link
Contributor

🔖 Issue Ticket

Ticket

✍️ Description

마이페이지 내 댓글 수정 및 삭제 기능.
수정 및 삭제기능은 제대로 구현 되었으나 리스트 reload가 아직 조금 부족합니다. 리팩토링 기간에 수정하도록 하겠습니다.

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • 수정 및 삭제 후 리스트 reload 문제 해결
  • 코드 리팩토링 ‼️

구현 화면

  • 댓글 수정
    스크린샷 2024-07-31 시간: 23 48 08
  • 댓글 삭제
    스크린샷 2024-07-31 시간: 23 48 15

@JeonYumin94 JeonYumin94 added Priority: Medium 🔖 우선순위 보통 Type: Feature ✨ 신규 기능 labels Jul 31, 2024
@JeonYumin94 JeonYumin94 requested a review from a team July 31, 2024 14:49
@JeonYumin94 JeonYumin94 self-assigned this Jul 31, 2024
<div
onClick={() => handleCommentClick(comment.epigramId)}
onKeyDown={(event) => handleKeyDown(event, comment.epigramId)}
role='button'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Question
button 태그 사용 안 하시고 div태그에 role=button 하신 점 궁금합니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공용 컴포넌트 그대로 사용했습니다...!

Copy link
Contributor

@jisurk jisurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 고생하셨습니다~~

@JeonYumin94 JeonYumin94 merged commit 8e76899 into epic/FE-27--my-page Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium 🔖 우선순위 보통 Type: Feature ✨ 신규 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants