Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ... args from estimate_secondary() #894

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Remove ... args from estimate_secondary() #894

merged 2 commits into from
Dec 12, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #869.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit b4a7697 Dec 12, 2024
9 checks passed
@sbfnk sbfnk deleted the remove_dot_args branch December 12, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbfnk sbfnk sbfnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

... in estimate_secondary not used
2 participants
@jamesmbaazam @sbfnk