Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docker action #891

Merged
merged 3 commits into from
Dec 12, 2024
Merged

remove docker action #891

merged 3 commits into from
Dec 12, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Dec 12, 2024

Description

This PR closes #864 by removing the action altogether.

Presumably we can also remove the .devcontainer directory?

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam
Copy link
Contributor

Presumably we can also remove the .devcontainer directory?

Yes.

@seabbs seabbs requested a review from jamesmbaazam December 12, 2024 13:47
@seabbs
Copy link
Contributor

seabbs commented Dec 12, 2024

We should also remove the out of date built images so people don't accidently use them. @jamesmbaazam I tagged you to review as the unfortunate first responder - happy to do it if you are rushed

@sbfnk sbfnk added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@sbfnk sbfnk added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 4e7322f Dec 12, 2024
11 checks passed
@sbfnk sbfnk deleted the remove-docker branch December 12, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants