Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for NA in multi.distspec #859

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Fix check for NA in multi.distspec #859

merged 4 commits into from
Nov 20, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #858.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

R/opts.R Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
jamesmbaazam and others added 2 commits November 20, 2024 20:08
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
@sbfnk sbfnk merged commit e9cb977 into main Nov 20, 2024
8 of 9 checks passed
@sbfnk sbfnk deleted the issue-858 branch November 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when adding multiple delays with and without max
2 participants