Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce alpha prior sd again #856

Merged
merged 4 commits into from
Nov 19, 2024
Merged

reduce alpha prior sd again #856

merged 4 commits into from
Nov 19, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Nov 15, 2024

Suggesting to revert the recent change in the prior sd of alpha (#840) in the light of the issues seen in #847 and the exploration in #855.

@sbfnk sbfnk requested review from seabbs and jamesmbaazam November 15, 2024 14:21
@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 15, 2024

This will re-open the issue in epiverse-trace/howto#81 which will have to (and can) be addressed in some other way.

@jamesmbaazam
Copy link
Contributor

This will re-open the issue in epiverse-trace/howto#81 which will have to (and can) be addressed in some other way.

Isn't the solution to use the prior in the previous version? In the how-to, the concern is not about divergences but how to set up a model.

jamesmbaazam
jamesmbaazam previously approved these changes Nov 15, 2024
Copy link
Contributor

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 15, 2024

This will re-open the issue in epiverse-trace/howto#81 which will have to (and can) be addressed in some other way.

Isn't the solution to use the prior in the previous version? In the how-to, the concern is not about divergences but how to set up a model.

The solution is indeed to either use prior = "infections" or manually set alpha_sd in the howto.

@sbfnk sbfnk merged commit 64d17ee into main Nov 19, 2024
9 checks passed
@sbfnk sbfnk deleted the alpha branch November 19, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants