Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of alpha #831

Merged
merged 9 commits into from
Oct 23, 2024
Merged

Documentation of alpha #831

merged 9 commits into from
Oct 23, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Oct 16, 2024

Description

This PR closes #829.

It clarifies the documentation of alpha.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk enabled auto-merge October 16, 2024 13:32
@sbfnk sbfnk disabled auto-merge October 16, 2024 13:59
@sbfnk sbfnk marked this pull request as draft October 16, 2024 13:59
@sbfnk sbfnk marked this pull request as ready for review October 16, 2024 14:15
@sbfnk sbfnk enabled auto-merge October 16, 2024 14:15
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting the prior change was intentional based on prior predictives but happy for it to be widened. It might be good to split this out from the doc change.

@jamesmbaazam
Copy link
Contributor

Agree with splitting out the prior change.

@sbfnk sbfnk requested a review from seabbs October 17, 2024 08:09
@sbfnk
Copy link
Contributor Author

sbfnk commented Oct 23, 2024

@seabbs just fyi I think the failure here is again related to some issue with the caching in the cmdstan action on macOS. Will clear and re-trigger checks.

@sbfnk sbfnk added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 1dd2131 Oct 23, 2024
9 checks passed
@sbfnk sbfnk deleted the alpha-doc branch October 23, 2024 16:35
@seabbs
Copy link
Contributor

seabbs commented Oct 23, 2024

I also cleared it an reran. I think a patch fix here would be to set the cache to auto-delete after say a week . Might strike a better balance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

definition of alpha in GP spectral densities
3 participants