Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 824: delete sentence about warning if non-zero first element #825

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Issue 824: delete sentence about warning if non-zero first element #825

merged 1 commit into from
Oct 15, 2024

Conversation

kaitejohnson
Copy link
Contributor

@kaitejohnson kaitejohnson commented Oct 11, 2024 •
edited
Loading

Description

This PR closes #824, as discussed #799 (comment)

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@seabbs seabbs requested a review from jamesmbaazam October 12, 2024 20:23
@kaitejohnson kaitejohnson marked this pull request as ready for review October 13, 2024 21:10
This was referenced Oct 14, 2024
Closed
Merged
@jamesmbaazam
Copy link
Contributor

CI failures here should be fixed after #827 is merged and this branch is rebased on main. Issue is described in #826.

jamesmbaazam
jamesmbaazam approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kaitejohnson.

@jamesmbaazam jamesmbaazam added this pull request to the merge queue Oct 15, 2024
Merged via the queue into epiforecasts:main with commit ac08a83 Oct 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmbaazam jamesmbaazam jamesmbaazam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hot fix to remove sentence in vignette about 0 indexing of GI warning
2 participants
@kaitejohnson @jamesmbaazam