Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_dist -> fix_parameters #733

Merged
merged 7 commits into from
Sep 20, 2024
Merged

fix_dist -> fix_parameters #733

merged 7 commits into from
Sep 20, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Aug 2, 2024

Description

This PR closes #715.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 81258af is merged into main:

  • ✔️default: 33.9s -> 35.3s [-14.92%, +23.37%]
  • ✔️no_delays: 39.9s -> 43.7s [-10.59%, +29.37%]
  • ✔️random_walk: 10.4s -> 9.96s [-11.72%, +2.77%]
  • ✔️stationary: 19.6s -> 19.3s [-13.01%, +9.43%]
  • ✔️uncertain: 53.8s -> 52.2s [-21.96%, +15.89%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk sbfnk enabled auto-merge August 2, 2024 13:28
@sbfnk sbfnk requested a review from jamesmbaazam August 2, 2024 13:28
NEWS.md Outdated Show resolved Hide resolved
R/deprecated.R Outdated Show resolved Hide resolved
R/deprecated.R Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You could also add a test for deprecation of fix_dist().

@sbfnk sbfnk requested a review from jamesmbaazam September 20, 2024 09:32
NEWS.md Outdated Show resolved Hide resolved
R/deprecated.R Outdated Show resolved Hide resolved
R/deprecated.R Outdated Show resolved Hide resolved
jamesmbaazam
jamesmbaazam previously approved these changes Sep 20, 2024
Copy link
Contributor

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 20, 2024

@jamesmbaazam can you still approve this now that you've co-authored? If not we might need @seabbs's help to allow this to be merged.

jamesmbaazam
jamesmbaazam previously approved these changes Sep 20, 2024
@jamesmbaazam
Copy link
Contributor

Is the touchstone failure being fixed by any of you? @seabbs @sbfnk

@sbfnk sbfnk added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 20, 2024
@sbfnk sbfnk added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 998b0e5 Sep 20, 2024
10 of 12 checks passed
@sbfnk sbfnk deleted the fix-params branch September 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename fix_dist
2 participants