-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_dist -> fix_parameters #733
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 81258af is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. You could also add a test for deprecation of fix_dist()
.
Co-authored-by: James Azam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me.
Co-authored-by: James Azam <[email protected]>
@jamesmbaazam can you still approve this now that you've co-authored? If not we might need @seabbs's help to allow this to be merged. |
Description
This PR closes #715.
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request