-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate secondary #591
Simulate secondary #591
Conversation
9f2de75
to
812ecaa
Compare
812ecaa
to
6e691bd
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 97e07cf is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A bit of a painful merge I think.
Co-authored-by: Sam Abbott <[email protected]>
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8d0f69c is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 65b3043 is merged into main:
|
All changes since last review were merges / minor doc changes so merging as is. |
* `simulate_secondary()` -> `convolve_and_scale()` * simulate_secondary function * add tests * add news item * load data.table explicitly in example * Apply suggestions from code review Co-authored-by: Sam Abbott <[email protected]> * add correct documentation --------- Co-authored-by: Sam Abbott <[email protected]>
* `simulate_secondary()` -> `convolve_and_scale()` * simulate_secondary function * add tests * add news item * load data.table explicitly in example * Apply suggestions from code review Co-authored-by: Sam Abbott <[email protected]> * add correct documentation --------- Co-authored-by: Sam Abbott <[email protected]>
Description
This PR closes #563 by introducing a new function
simulate_secondary()
. The existing function of that named has been renamed toconvolve_and_scale()
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request