Deprecate init_cumulative_fit()
#572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
commented
Feb 21, 2024
jamesmbaazam
changed the title
jamesmbaazam
changed the title
init_cumulative_fit()
sbfnk
requested changes
Feb 22, 2024
There was a problem hiding this comment.
- Since
stan_opts() is the function that users actually interact with, can we add a deprecation warning there? Something like
lifecycle::deprecate_warn(
"1.5.0", "stan_opts(init_fit)",
details = "This argument will be removed in version 2.0.0."
)- Can we add deprecation tests? For an example see
EpiNow2/tests/testthat/test-dist_spec.R
Line 230 in 4c1f460
- There are some
lintrwarnings about trailing whitespace
I didn't know about deprecation tests but was wondering about that yesterday. Good to know :). |
jamesmbaazam
force-pushed
the
deprecate-init_cumulative_fit
branch
from
a282ae3 to
3964e3e
Compare
jamesmbaazam
commented
Feb 22, 2024
sbfnk
approved these changes
Feb 26, 2024
jamesmbaazam
added a commit
that referenced
this pull request
Feb 26, 2024
* Point out deprecation of "cumulative" option * Deprecate init_cumulative_fit function * Add NEWS item * Add PR number to NEWS item * Linting: trailing white spaces * Change versions * Add deprecation warning for init_fit argument * Move deprecation statement to separate paragraph * Add deprecation test * Add reviewer * Move deprecation warning to where the argument is called * Revise deprecation message * Don't use explicit namespacing * Throw deprecation warning if init_fit argument isn't NULL * Fix test
sbfnk
pushed a commit
that referenced
this pull request
May 3, 2024
* Point out deprecation of "cumulative" option * Deprecate init_cumulative_fit function * Add NEWS item * Add PR number to NEWS item * Linting: trailing white spaces * Change versions * Add deprecation warning for init_fit argument * Move deprecation statement to separate paragraph * Add deprecation test * Add reviewer * Move deprecation warning to where the argument is called * Revise deprecation message * Don't use explicit namespacing * Throw deprecation warning if init_fit argument isn't NULL * Fix test
sbfnk
pushed a commit
that referenced
this pull request
May 3, 2024
* Point out deprecation of "cumulative" option * Deprecate init_cumulative_fit function * Add NEWS item * Add PR number to NEWS item * Linting: trailing white spaces * Change versions * Add deprecation warning for init_fit argument * Move deprecation statement to separate paragraph * Add deprecation test * Add reviewer * Move deprecation warning to where the argument is called * Revise deprecation message * Don't use explicit namespacing * Throw deprecation warning if init_fit argument isn't NULL * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #541.
This PR deprecates the
init_cumulative_fit()function.Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).After the initial Pull Request