rename simulate_infections -> forecast_infections #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbfnk
force-pushed
the
forecast-infections
branch
from
b3fe534 to
782c8e9
Compare
seabbs
previously approved these changes
Feb 14, 2024
Co-authored-by: Sam Abbott <[email protected]>
seabbs
approved these changes
Feb 14, 2024
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* rename simulate_infections -> forecast_infections * Apply suggestions from code review Co-authored-by: Sam Abbott <[email protected]> * fix typo --------- Co-authored-by: Sam Abbott <[email protected]>
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* rename simulate_infections -> forecast_infections * Apply suggestions from code review Co-authored-by: Sam Abbott <[email protected]> * fix typo --------- Co-authored-by: Sam Abbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with the discussion in #509 and renames
simulate_infectionstoforecast_infections. This now follows the same terminology ofsimulate_secondaryandforecast_secondary: a forecast is done from a fit to existing data, a simulation from first principles. We could also do it the other way round and change the..._secondaryfunction names but this version made more sense to me.Deprecation of
simulate_infectionsis transient until a new function simulating from given parameters / initial conditions has been implemented.