Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace update_list() with utils::modifyList() #491

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Replace update_list() with utils::modifyList() #491

merged 11 commits into from
Nov 3, 2023

Conversation

jamesmbaazam
Copy link
Contributor

@jamesmbaazam jamesmbaazam commented Oct 27, 2023 •
edited
Loading

This PR will close #488 by:

  • Hard deprecating the exported utility function update_list()
  • Replacing update_list() with utils::modifyList() everywhere

@jamesmbaazam jamesmbaazam changed the title Replace with Replace with update_list() with utils::modifyList() Oct 27, 2023
@jamesmbaazam jamesmbaazam self-assigned this Oct 27, 2023
@jamesmbaazam jamesmbaazam changed the title Replace with update_list() with utils::modifyList() Replace update_list() with utils::modifyList() Oct 27, 2023
seabbs
seabbs reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from line break (😄) and the more serious issue of failing all CI checks!

NEWS.md Outdated Show resolved Hide resolved
@jamesmbaazam jamesmbaazam marked this pull request as ready for review November 3, 2023 11:31
seabbs
seabbs approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy for this to be merged once passing checks.

@jamesmbaazam jamesmbaazam merged commit af8c1f3 into main Nov 3, 2023
9 checks passed
@jamesmbaazam jamesmbaazam deleted the remove-update_list branch November 3, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees

@jamesmbaazam jamesmbaazam

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is EpiNow2::update_list() utils::modifyList()?
2 participants
@jamesmbaazam @seabbs