You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes#485 and brings the vignette into line with code. As in the issue this has shown performance benefits in epinowcast though here we can't use inv_square as I think it is not yet in the latest version of rstan.
We could also change some variable names to make this all a bit clearer if we wish.
The reason will be displayed to describe this comment to others. Learn more.
Nice! Suggested some variable renaming as sqrt_phi doesn't really fit any more.
I hadn't realised touchstone doesn't work with branches in forks - worth pushing to a branch in the original remote and PRing again to see any noticable changes in efficiency?
I hadn't realised touchstone doesn't work with branches in forks - worth pushing to a branch in the original remote and PRing again to see any noticable changes in efficiency?
This is a PR from the original remote isn't it? I've just called the branch seabbs/update-phi-parameterisation?
I hadn't realised touchstone doesn't work with branches in forks - worth pushing to a branch in the original remote and PRing again to see any noticable changes in efficiency?
This is a PR from the original remote isn't it? I've just called the branch seabbs/update-phi-parameterisation?
Complete shot in the dark but perhaps there's an issue with slashes in branch names?
Yes, potentially. We see transcient failures for epinowcast where that branch naming approach is pretty common - I haven't checked to see if its always branches with slashes that fail.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 151a8a0 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation.
Complete shot in the dark but perhaps there's an issue with slashes in branch names?
Yes, potentially. We see transcient failures for epinowcast where that branch naming approach is pretty common - I haven't checked to see if its always branches with slashes that fail.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #485 and brings the vignette into line with code. As in the issue this has shown performance benefits in
epinowcastthough here we can't useinv_squareas I think it is not yet in the latest version ofrstan.We could also change some variable names to make this all a bit clearer if we wish.