Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partial matching of dist to distribution in dist_spec() #480

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix partial matching of dist to distribution in dist_spec() #480

merged 1 commit into from
Oct 16, 2023

Conversation

jamesmbaazam
Copy link
Contributor

@jamesmbaazam jamesmbaazam commented Oct 13, 2023 •
edited
Loading

This PR closes #473. Details of the issue are provided in the linked issue.

@jamesmbaazam jamesmbaazam requested a review from seabbs October 13, 2023 15:34
sbfnk
sbfnk approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@sbfnk sbfnk merged commit 9f77b48 into main Oct 16, 2023
8 checks passed
@sbfnk sbfnk deleted the fix-pmatch branch October 16, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbfnk sbfnk sbfnk approved these changes

@seabbs seabbs Awaiting requested review from seabbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix partial matching of dist to distribution in get_generation_time()
2 participants
@jamesmbaazam @sbfnk