Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples with long runtimes #459

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Remove examples with long runtimes #459

merged 6 commits into from
Oct 3, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 27, 2023

Partly by storing some model results as data. See #458 (comment)

Closes #430.

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 27, 2023

46min -> 15min so at least that's something.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Do you think CRAN are going to be okay with this? In the past they have not been which is why epinowcast just extdata and loads in the example from a function.

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 27, 2023

Good question - also the increased size of data/ might raise eyebrows.

This also reminded me that we have example outputs in inst in rbi which didn't cause issues with CRAN. Will move it there.

seabbs
seabbs previously approved these changes Sep 29, 2023
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbfnk
Copy link
Contributor Author

sbfnk commented Oct 3, 2023

Source tarball is now 6.6 MB which should be fine for CRAN.

@sbfnk sbfnk merged commit 89cee00 into main Oct 3, 2023
4 of 9 checks passed
@sbfnk sbfnk deleted the remove-examples branch October 3, 2023 09:40
NEWS.md Show resolved Hide resolved
@sbfnk sbfnk mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long example run times
3 participants