-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stan model implementation of simulate_secondary
#563
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
simulate_secondary
is a nice function for convolutions with potentially time-varying delays and scaling, implemented in R.Whilst this is great I think it would be nice to have a
simulate_secondary
function that mirrorssimulate_infections
and uses the corresponding stan model to simulate from given parameters. This could benefit from further model updates (and already e.g. can handle gamma distributed delays) and e.g. the new distribution interface but for the moment wouldn't be able to have time-varying convolution parameters. Implementing this would also enable the deprecations mentioned in #520.We could
simulate_secondary
with the function outlined abovesimulate_secondary
and add the function outlined above with different namesimulate_secondary
and add the function outlined above assimulate_secondary
My initial inclination would be (3) with an aim to eventually deprecate the function when time-varying convolutions become available in the stan model.
The text was updated successfully, but these errors were encountered: