Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stan model implementation of simulate_secondary #563

Closed
sbfnk opened this issue Feb 20, 2024 · 2 comments · Fixed by #591
Closed

stan model implementation of simulate_secondary #563

sbfnk opened this issue Feb 20, 2024 · 2 comments · Fixed by #591

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Feb 20, 2024

simulate_secondary is a nice function for convolutions with potentially time-varying delays and scaling, implemented in R.

Whilst this is great I think it would be nice to have a simulate_secondary function that mirrors simulate_infections and uses the corresponding stan model to simulate from given parameters. This could benefit from further model updates (and already e.g. can handle gamma distributed delays) and e.g. the new distribution interface but for the moment wouldn't be able to have time-varying convolution parameters. Implementing this would also enable the deprecations mentioned in #520.

We could

  1. replace simulate_secondary with the function outlined above
  2. keep simulate_secondary and add the function outlined above with different name
  3. rename simulate_secondary and add the function outlined above as simulate_secondary
  4. not do anything and keep things as they are

My initial inclination would be (3) with an aim to eventually deprecate the function when time-varying convolutions become available in the stan model.

@seabbs
Copy link
Contributor

seabbs commented Feb 20, 2024

agree

@sbfnk sbfnk moved this to Todo in EpiNow2 v1.5.0 Feb 20, 2024
@sbfnk sbfnk removed this from EpiNow2 v1.5.0 Feb 21, 2024
@sbfnk sbfnk removed this from EpiNow2 v2.0.0 Feb 29, 2024
@sbfnk sbfnk moved this to In Progress in EpiNow2 v1.5.0 Feb 29, 2024
@sbfnk
Copy link
Contributor Author

sbfnk commented Feb 29, 2024

Moving this to 1.5.0 so as to be able to bring forward #520 in the aim for a "cleaner" 2.0.0.

@sbfnk sbfnk mentioned this issue Mar 1, 2024
7 tasks
@sbfnk sbfnk closed this as completed in #591 Mar 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in EpiNow2 v1.5.0 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants