Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate init_cumulative_fit #541

Closed
sbfnk opened this issue Feb 6, 2024 · 1 comment · Fixed by #572
Closed

Deprecate init_cumulative_fit #541

sbfnk opened this issue Feb 6, 2024 · 1 comment · Fixed by #572
Assignees

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Feb 6, 2024

          we should depreciate this at some point. I don't think it helps and its just code to carry around

Originally posted by @seabbs in #537 (comment)

@sbfnk
Copy link
Contributor Author

sbfnk commented Feb 12, 2024

In the first instance this needs a deprecation warning similar to the one e.g. in get_dist:

EpiNow2/R/get.R

Line 182 in 49473e8

get_dist <- function(data, disease, source, max_value = 14, fixed = FALSE) {

@sbfnk sbfnk moved this to Todo in EpiNow2 v1.5.0 Feb 20, 2024
@jamesmbaazam jamesmbaazam self-assigned this Feb 21, 2024
@jamesmbaazam jamesmbaazam moved this from Todo to In Progress in EpiNow2 v1.5.0 Feb 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in EpiNow2 v1.5.0 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants