Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sam Abbott <[email protected]>
  • Loading branch information
sbfnk and seabbs authored Mar 12, 2024
1 parent 75ce0c2 commit eac039f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion R/checks.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ check_reports_valid <- function(reports, model) {
#'
#' @description
#' `check_stan_delay()` checks that the supplied data is a `<dist_spec>`,
#' that it is lognormal or gamma, and that it has a finite maximum.
#' that it is a supported distribution, and that is has a finite maximum.
#'
#' @param dist A `dist_spec` object.`
#' @importFrom checkmate assert_class
Expand Down
2 changes: 1 addition & 1 deletion inst/dev/design_dist.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This interface could be of potential use to other packages (e.g. `epinowcast`, `

## Proposed interface

We are an proposing an dinterface similar to what is used in `{rstanarm}` and `{distributions3}`, where probability distributions are called according to their capitalised names. This avoids masking `base::gamma()` (although we still mask `stats::Gamma`). There is potential for integration especially with `{distributionS3}`. Parameters are nested according to the same syntax.
We are an proposing an interface similar to what is used in `{rstanarm}` and `{distributions3}`, where probability distributions are called according to their capitalised names. This avoids masking `base::gamma()` (although we still mask `stats::Gamma`). There is potential for integration especially with `{distributionS3}`. Parameters are nested according to the same syntax.

Examples:
```{r}
Expand Down

0 comments on commit eac039f

Please sign in to comment.