-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix training related failures #616
Merged
Merged
+196
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienVig
added
bug
Something isn't working
discojs
Related to Disco.js
server
Related to the server
labels
Feb 1, 2024
Closed
…into 610-training-timeout-julien
…into 610-training-timeout-julien
JulienVig
commented
Feb 6, 2024
JulienVig
commented
Feb 6, 2024
JulienVig
commented
Feb 6, 2024
JulienVig
commented
Feb 6, 2024
tharvik
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small non-blocking comments, merge at will 🚀
discojs/discojs-core/src/dataset/data/preprocessing/tabular_preprocessing.ts
Show resolved
Hide resolved
Co-authored-by: Valérian Rousset <[email protected]>
Co-authored-by: Valérian Rousset <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple relatively small bugs happening when training with DISCO.
Fixes Fix local test failure #612
One local test was failing with a timeout on my laptop. It happens that the test timeout was too short for my humble machine to finish the test. I simply increased the timeout value.
Fixes Training on Titanic has a NaN loss #615
The training Loss was NaN when training the Titanic task. There were two issues:
Before: training accuracy constant at 0.61 and NaN Loss, now the training accuracy increases throughout the epochs (as well as the validation) while the loss decreases monotonically, both from a Node.js script and from the web-client.
Fixes Train Collaboratively raises error during training #610
See issue for detailed description of bug and fix. While the client used to send the weights and then request the new weights separately, the server now automatically sends back the new weights after receiving the local contribution. This change saves 1 RTT and importantly, ensures that events happen in the right order, which was previously causing timeouts.
Now training collaboratively doesn't timeout anymore. The training accuracy now increases monotonically to 70% while it was previously staying constant at 61% with NaN loss.