Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring created mismatched function calls #608

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

JulienVig
Copy link
Collaborator

After this commit changed the method isBuilt() to be the getter get built(), the front end was raising the error datasetBuilder.isBuilt() is not a function.

I changed the getter call from datasetBuilder.isBuilt() to datasetBuilder.built (getters are called without parentheses

Same thing for get size()

@JulienVig JulienVig changed the title Refactoring created mismatched function names Refactoring created mismatched function calls Jan 11, 2024
@JulienVig JulienVig self-assigned this Jan 11, 2024
@EduardDurech
Copy link
Collaborator

I'm just testing Codium for Doc creation, let me know if the bots responses were accurate above

@martinjaggi
Copy link
Member

fixes issue #607

@JulienVig
Copy link
Collaborator Author

I'm just testing Codium for Doc creation, let me know if the bots responses were accurate above

The doc is accurate but IMO it doesn't add much, it's a very literal description of the "if/else"'s and probably doesn't help someone with the basic programming skills to better understand what's happening. It's better than nothing but I would prefer a higher-level description that addresses potential confusions and design choices (and potentially human if need be).

@martinjaggi
Copy link
Member

want to mark it as ready to review, and merge?

(if possible i would avoid big restructurings on the docs side for now and aim for the minimal changes needed to get things working again, and to clarify some things in the markdown docs if it helps new users getting started?)

@JulienVig
Copy link
Collaborator Author

Yes, so far I've only been updating markdown files and fixing typos in the code as I see them

@JulienVig
Copy link
Collaborator Author

@EduardDurech is busy this week, @martinjaggi do you have time to review it?

@EduardDurech EduardDurech removed the request for review from martinjaggi January 29, 2024 14:21
@EduardDurech
Copy link
Collaborator

Small commit so able to check

@EduardDurech EduardDurech merged commit be4ec82 into develop Jan 29, 2024
17 checks passed
@EduardDurech EduardDurech deleted the 607-training-fails-julien branch January 29, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants