-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring created mismatched function calls #608
Conversation
I'm just testing Codium for Doc creation, let me know if the bots responses were accurate above |
fixes issue #607 |
The doc is accurate but IMO it doesn't add much, it's a very literal description of the "if/else"'s and probably doesn't help someone with the basic programming skills to better understand what's happening. It's better than nothing but I would prefer a higher-level description that addresses potential confusions and design choices (and potentially human if need be). |
want to mark it as ready to review, and merge? (if possible i would avoid big restructurings on the docs side for now and aim for the minimal changes needed to get things working again, and to clarify some things in the markdown docs if it helps new users getting started?) |
Yes, so far I've only been updating markdown files and fixing typos in the code as I see them |
@EduardDurech is busy this week, @martinjaggi do you have time to review it? |
Small commit so able to check |
After this commit changed the method
isBuilt()
to be the getterget built()
, the front end was raising the errordatasetBuilder.isBuilt() is not a function
.I changed the getter call from
datasetBuilder.isBuilt()
todatasetBuilder.built
(getters are called without parenthesesSame thing for
get size()