Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Align chart for ingress TLS configuration(#178) #179

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

alezander86
Copy link
Contributor

@alezander86 alezander86 commented May 3, 2024

Description

This pull request introduces updates to the Tekton Pipelines Library Helm chart, focusing on improving the dashboard ingress configuration for better flexibility and usability. Changes have been made to README.md, _helpers.tpl, ingress.yaml, and values.yaml files to allow a more dynamic setup of the Tekton dashboard URL and to facilitate the configuration of TLS for the ingress. These enhancements aim to provide users with a more intuitive way of setting up the Tekton dashboard access, especially in environments with varying DNS configurations.

Fixes

Updated ingress configuration to support dynamic dashboard URL based on the namespace or a specified host.
Improved TLS configuration documentation and options for the dashboard ingress.
Streamlined dashboard ingress setup for enhanced user experience.
Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

The updates were tested by deploying the modified Helm chart in a Kubernetes cluster with different configurations for the dashboard ingress host and TLS settings. The deployment was verified to work as expected in scenarios with and without specified hosts, and with custom DNS settings.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@alezander86 alezander86 requested a review from a team as a code owner May 3, 2024 16:50
@alezander86 alezander86 self-assigned this May 9, 2024
@alezander86 alezander86 added enhancement New feature or request bug Something isn't working labels May 9, 2024
charts/pipelines-library/values.yaml Outdated Show resolved Hide resolved
charts/pipelines-library/values.yaml Outdated Show resolved Hide resolved
charts/pipelines-library/templates/dashboard/_helpers.tpl Outdated Show resolved Hide resolved
charts/pipelines-library/templates/dashboard/ingress.yaml Outdated Show resolved Hide resolved
charts/pipelines-library/templates/dashboard/ingress.yaml Outdated Show resolved Hide resolved
@alezander86 alezander86 force-pushed the EPMDEDP-13645 branch 2 times, most recently from 117c21e to 6399879 Compare May 17, 2024 16:08
@SergK SergK merged commit 904d6f4 into master May 31, 2024
9 checks passed
@SergK SergK deleted the EPMDEDP-13645 branch May 31, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants