-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings button in quicksettings #347
base: master
Are you sure you want to change the base?
Conversation
If this is a feature we want, the parameters might need another look. If we're passing a reference to |
6a904c7
to
ed0fd5b
Compare
Made the suggested changes |
@eonpatapon @pakaoraki Is this a feature we want? I'm happy with it since it's in line with the rest of the shell, but I don't want to merge it unless everyone else is happy with it @ChrisLauinger77 Could you fix the merge conflicts please, and sort the linter issues? Other than that LGTM :) |
I will look into it in the evening |
ed0fd5b
to
b6a667e
Compare
The merge conflict is resolved - I do not see any linter issues with the code I added though. |
You should be able to see under the Checks tab -> lint -> 'Run linter target' dropdown |
Now I can see it - it did not show up after I pushed and waited 30 min |
b6a667e
to
5cf6d36
Compare
I think I have it all covered now ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working in my VM, LGTM
Also tested with #355, correctly hidden on the lock screen too
Sorry for the very long delay. I had the same idea some time ago, but I never implemented it. So I personally like this feature. |
fast way to access extension settings