Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings button in quicksettings #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChrisLauinger77
Copy link

fast way to access extension settings

@ChrisLauinger77
Copy link
Author

Bildschirmfoto vom 2024-11-01 07-57-37

@stuarthayhurst
Copy link
Collaborator

If this is a feature we want, the parameters might need another look. If we're passing a reference to CaffeineExtension in, then passing the settings, path and name in is redundant, since they can all be acquired from the CaffeineExtension reference

@ChrisLauinger77
Copy link
Author

Made the suggested changes

@stuarthayhurst
Copy link
Collaborator

@eonpatapon @pakaoraki Is this a feature we want? I'm happy with it since it's in line with the rest of the shell, but I don't want to merge it unless everyone else is happy with it

@ChrisLauinger77 Could you fix the merge conflicts please, and sort the linter issues? Other than that LGTM :)

@ChrisLauinger77
Copy link
Author

I will look into it in the evening

@ChrisLauinger77
Copy link
Author

The merge conflict is resolved - I do not see any linter issues with the code I added though.
"make lint" does not work on my local machine - where can I see what it does not like on github page ?

@stuarthayhurst
Copy link
Collaborator

stuarthayhurst commented Jan 7, 2025

You should be able to see under the Checks tab -> lint -> 'Run linter target' dropdown

@ChrisLauinger77
Copy link
Author

ChrisLauinger77 commented Jan 7, 2025

Now I can see it - it did not show up after I pushed and waited 30 min

@ChrisLauinger77
Copy link
Author

ChrisLauinger77 commented Jan 7, 2025

I think I have it all covered now ...
Lets see when the workflow checks run again ...

Copy link
Collaborator

@stuarthayhurst stuarthayhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in my VM, LGTM

Also tested with #355, correctly hidden on the lock screen too

@pakaoraki
Copy link
Collaborator

Sorry for the very long delay. I had the same idea some time ago, but I never implemented it. So I personally like this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants