Add privacy statement to relevant places #941
Conversation
There was a problem hiding this comment.
Noticed a few different issues, including some small but highly consequential casing errors, plus a question or two; comments in-line.
Also noticed some minor UI issues, though I'd be okay with addressing these in a follow-up PR given the time constraints we're under.
Margin under the footer on public pages is missing (that green line is the top of my taskbar; I can't scroll down any further):
Similarly missing on internal pages:
Just as an FYI, it looks like our markdown renderer can't do tables. Not that I was planning to use any, but maybe something we want to fix one day?
Also as an FYI, I've been getting some new deprecation warnings when running ACC locally. Seems to be related to recent Smarty updates:
| @@ -0,0 +1,7 @@ | |||
| <div class="row"> | |||
| <p class="legal-info"> | |||
| By submitting this form, you agree to your information being processed to fulfil your request in | |||
There was a problem hiding this comment.
TIL that you spell "fulfill" incorrectly in addition to "color". ;)
There was a problem hiding this comment.
Genuine question - does this legally matter? I can't recall if we have a defined preferred ENGVAR in the tool at all.
I can't imagine it being important immediately, but it might be something to come back to.
There was a problem hiding this comment.
Hmm, I'm really not sure. Technically the legal venue here would be the US, but I have a hard time believing that the use of British English would nullify the agreement.
I would say let's kick this down the road to a larger discussion of what ENGVAR we want to use; I can't see this being any issue in the near-term future. (Or if it is, I'm sure we'll find out about it.)
| @@ -34,6 +34,7 @@ | |||
| {$formCommentsHelp} | |||
| </small> | |||
| </div> | |||
| {include file="request/legal-info.tpl"} | |||
There was a problem hiding this comment.
Should this be customizable as with the rest of the form? Thinking about use cases like the ruwiki form, though maybe you've already thought about that and this is a v2 thing?
There was a problem hiding this comment.
I hadn't thought about that, but the policy says "in English (as well as any other language versions if applicable)". For now, I think a gtranslate of the legal-info.tpl can be added to the existing dynamic header just fine, leaving the hard-coded English version here.
If we want to make this truly dynamic in a nice way, it's going to be a schema change (just nope).
There was a problem hiding this comment.
Fair enough. I think it would be a good idea to make it dynamic Eventually, but there's other multidomain stuff that I think is more impactful.
Not critical for now, but acknowledged for later.
Yes it can, we just don't have it enabled.
Already tracked as #794 |
This adds links to the WMCS TOS and our brand new {entry}.php/privacy
pages, which render the privacy statement in the correct context from a
markdown file. Links have been added to both public and private footers,
and to relevant data submission forms (request and register) for when
users start using the service.
I've also taken the opportunity to sassify the public stylesheet.
|
I think that's mostly all fixed now. I've even enabled Markdown tables for you. |
This adds links to the WMCS TOS and our brand new {entry}.php/privacy pages, which render the privacy statement in the correct context from a markdown file. Links have been added to both public and private footers, and to relevant data submission forms (request and register) for when users start using the service.
I've also taken the opportunity to sassify the public stylesheet.