-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to add multiple request forms #734
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
210b4d5
Add request form management UI
stwalkerster 2ae83c5
Don't permit queue to be disabled if it's in use by a form
stwalkerster ba96c7d
Column for request form, and show on zoom page
stwalkerster dafb608
Fields for editing help text
stwalkerster 0a26b0c
Show the header; fairly important to highlight there's no text by def…
stwalkerster a8cfd57
Add existing form as seed data in migration script
stwalkerster a4e9f9c
Adjust the format of the endpoint URL to make it easier to deal with.
stwalkerster 675fe54
Implement the forms on the frontend.
stwalkerster be62783
Fix default seed for prod
stwalkerster f85b725
Fix missing constructor parameters
stwalkerster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because PHP.
Actually, because the
get*()
methods in RequestForm are type-restricted to be a string, and PHP defaults variables to null. Since these are required fields, I don't really want to make them nullable (thestring?
type annotation)For both creation and edits,
PageRequestFormManagement
calls thepopulateFromObject
method to make it easier to set all the field assignments on the template, but for new objects it's done viapopulateFromObject(new RequestForm())
, thus all the fields are default values, and (without this change) the fields are all null which doesn't match the type annotation on theget*()
methods. For a recent example of this sort of thing happening in prod, see #754