docs: Fix GatewayClass configuration in migrating-to-envoy.md #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change the gateway class is not recognized. Signed-off-by: Lucas Resch <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4708 +/- ##
==========================================
+ Coverage 65.53% 65.54% +0.01%
==========================================
Files 211 211
Lines 31954 31954
==========================================
+ Hits 20940 20945 +5
+ Misses 9769 9766 -3
+ Partials 1245 1243 -2 ☔ View full report in Codecov by Sentry. |
|
please update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change the gateway class is not recognized. This is something I found out while going through the tutorial. I found the crucial hint in this PR: https://github.com/envoyproxy/gateway/pull/2298/files#diff-ecaad4050739f634620ff5b51657f0be0a0e7d85c28018d4d5d5222e7463777eR6
What type of PR is this?
What this PR does / why we need it:
Fix a configuration in the documentation.
Which issue(s) this PR fixes:
N/A
Release Notes: No