Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for Wasm code source TLS configuration #4492

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhaohuabing
Copy link
Member

API for: #4466

@zhaohuabing zhaohuabing requested a review from a team as a code owner October 21, 2024 07:36
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.69%. Comparing base (d9dd4e6) to head (620fe66).
Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4492      +/-   ##
==========================================
- Coverage   65.70%   65.69%   -0.02%     
==========================================
  Files         210      210              
  Lines       31432    31432              
==========================================
- Hits        20652    20648       -4     
- Misses       9587     9590       +3     
- Partials     1193     1194       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zirain
Copy link
Contributor

zirain commented Oct 21, 2024

I think we still need allow insecure registry in some cause, e.g. dev, localhost?

@zhaohuabing
Copy link
Member Author

zhaohuabing commented Oct 22, 2024

I think we still need allow insecure registry in some cause, e.g. dev, localhost?

We should avoid insecure as it poses potential security risks. A self-signed CA can be used for testing and development purposes.

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants