Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-rate-limit: add descriptor fill_interval lower bound #37375

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adisuissa
Copy link
Contributor

Commit Message: local-rate-limit: add descriptor fill_interval lower bound
Additional Description:
The local-rate-limit filter has a lower-bound fill_interval validation for the non-descriptor field.
This PR adds the same lower-bound to the fill_interval of a descriptor.
Note that this will reject previously valid configs that were under 50msec. In this case the config must change to be at least 50msec.

This was found by a fuzz test.

Risk Level: low
Testing: Added fuzz test corpus
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37375 was opened by adisuissa.

see: more, trace.

@adisuissa adisuissa marked this pull request as ready for review November 26, 2024 16:50
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants