fix: deployment error pop-up notification (#67)

env0 · Sep 26, 2023 · cd30acb · cd30acb
1 parent 5f81c9e
commit cd30acb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/notification-messages.ts b/src/notification-messages.ts
@@ -1,5 +1,6 @@
 import * as vscode from "vscode";
 import { ENV0_WEB_URL } from "./common";
+import stripAnsi from "strip-ansi";
 
 const MORE_INFO_BUTTON = "More info";
 
@@ -38,7 +39,11 @@ export const showErrorMessage = (
   errorMessage: string | undefined,
   linkProps: LinkProps
 ) => {
-  const message = `Deployment has failed for environment ${linkProps.environmentName}. Error: ${errorMessage}`;
+  const normalizedErrorMessage = stripAnsi(errorMessage || "").replace(
+    /│|╷|╵/g,
+    ""
+  );
+  const message = `Deployment has failed for environment ${linkProps.environmentName}. Error: ${normalizedErrorMessage}`;
   vscode.window.showErrorMessage(message, MORE_INFO_BUTTON).then((button) => {
     addLinkToEnvironment(button, linkProps);
   });

diff --git a/src/test/unit/auth.spec.ts b/src/test/unit/auth.spec.ts
@@ -1,5 +1,7 @@
 import * as jestMock from "jest-mock";
 import expect from "expect";
+// strip ansi mock must be imported before the tested module!!!
+import "./mocks/strip-ansi";
 // vscode mock must be imported before the tested module!!!
 import {
   contextMock,
@@ -9,7 +11,6 @@ import {
 } from "./mocks/vscode";
 import { AuthService } from "../../auth";
 import { mockValidateCredentialsRequest } from "./mocks/http";
-
 describe("authentication", () => {
   const keyId = "keyId";
   const secret = "secret";

diff --git a/src/test/unit/mocks/strip-ansi.ts b/src/test/unit/mocks/strip-ansi.ts
@@ -0,0 +1,2 @@
+import mock from "mock-require";
+mock("strip-ansi", (s: string) => s);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		import mock from "mock-require";
		mock("strip-ansi", (s: string) => s);