Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Environment ID argument #131

Merged
merged 6 commits into from
May 15, 2024
Merged

Feat: Environment ID argument #131

merged 6 commits into from
May 15, 2024

Conversation

yaronya
Copy link
Contributor

@yaronya yaronya commented May 12, 2024

Issue & Steps to Reproduce / Feature Request

When attempting to deploy an environment in a project containing multiple environments with the same name, there might be inconsistency regarding which environment gets deployed

Solution

Add the ability to deploy an environment by its ID using a new argument called environmentId. If both environmentId and environmentName are specified, environmentId takes precedence.

QA

  • Successfully deploy an existing environment using an ID
  • Successfully fail when deploying a non-existent environment using an ID
  • Successfully deploy an existing environment using a name
  • Successfully create a new environment using a name

@yaronya yaronya requested a review from a team May 12, 2024 19:40
Copy link

@Wassap124 Wassap124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaronya yaronya merged commit c5a4436 into master May 15, 2024
4 checks passed
@yaronya yaronya deleted the feat-environment-id-arg branch May 15, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants