Update programs to accept multiple oracle data #1153
Conversation
…te-programs-to-accept-multiple-oracle-data
| @@ -48,7 +48,7 @@ entropy-client={ version="0.3.0-rc.1", path="../client", default-features=false, | |||
| ] } | |||
|
|
|||
| # Programs | |||
| entropy-programs-runtime="0.10.0" | |||
| entropy-programs-runtime={ git="https://github.com/entropyxyz/programs.git", branch="master" } | |||
There was a problem hiding this comment.
I wonder where is a good place to put a reminder to ourselves that this will need re-publishing before the next release
There was a problem hiding this comment.
mmm maybe release checklist? maybe an issue?
| @@ -263,7 +272,7 @@ pub mod pallet { | |||
| bytecode: new_program.clone(), | |||
| configuration_schema: configuration_schema.clone(), | |||
| auxiliary_data_schema: auxiliary_data_schema.clone(), | |||
| oracle_data_pointer: oracle_data_pointer.clone(), | |||
| oracle_data_pointers: oracle_data_pointers.clone(), | |||
There was a problem hiding this comment.
Not directly related to this PR, but i can't see where we check that each oracle data pointer is not longer than MaxOracleKeyLength.
Or that the key exists in the oracle storage (although maybe that is less imported).
There was a problem hiding this comment.
yes I was going to make an issue but pretty much either or is fine, since the oracle data is a bounded vec, so either we check the length or we check that it exists (in which case a length check is not needed imo, will make an issue
Co-authored-by: peg <[email protected]>
JesseAbram
deleted the
update-programs-to-accept-multiple-oracle-data
branch
Updates core to allow for multiple oracle inputs
pairs with entropyxyz/programs#94