Skip to content

Commit

Permalink
Merge pull request #2020 from lcarva/EC-811
Browse files Browse the repository at this point in the history
Remove verify-definition Task
  • Loading branch information
lcarva authored Sep 27, 2024
2 parents 3e717c3 + 252544f commit 6637f3d
Show file tree
Hide file tree
Showing 9 changed files with 4 additions and 188 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
- name: Create and push the tekton bundle (quay.io/enterprise-contract/ec-task-bundle)
env:
TASK_REPO: quay.io/enterprise-contract/ec-task-bundle
TASKS: "tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml tasks/verify-definition/0.1/verify-definition.yaml"
TASKS: "tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml"
run: make task-bundle-snapshot TASK_REPO=$TASK_REPO TASK_TAG=$TAG ADD_TASK_TAG="$TAG_TIMESTAMP" TASKS=<( yq e ".spec.steps[].image? = \"$IMAGE_REPO:$TAG\"" $TASKS | yq 'select(. != null)')

- name: Download statistics
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -272,14 +272,14 @@ dev: IMAGE_REPO=localhost:$(REGISTRY_PORT)/ec
dev: PODMAN_OPTS=--tls-verify=false
dev: TASK_REPO=localhost:$(REGISTRY_PORT)/ec-task-bundle
dev: SKOPEO_ARGS=--src-tls-verify=false --dest-tls-verify=false
dev: TASKS:=$(shell T=$$(mktemp) && yq e ".spec.steps[].image? = \"localhost:$(REGISTRY_PORT)/ec\"" tasks/verify-enterprise-contract/*/verify-enterprise-contract.yaml tasks/verify-definition/*/verify-definition.yaml | yq 'select(. != null)' > "$${T}" && echo "$${T}")
dev: TASKS:=$(shell T=$$(mktemp) && yq e ".spec.steps[].image? = \"localhost:$(REGISTRY_PORT)/ec\"" tasks/verify-enterprise-contract/*/verify-enterprise-contract.yaml | yq 'select(. != null)' > "$${T}" && echo "$${T}")
dev: push-image task-bundle ## Push the ec-cli and v-e-c Task Bundle to the kind cluster setup via hack/setup-dev-environment.sh
@rm "$(TASKS)"

TASK_TAG ?= latest
TASK_REPO ?= quay.io/enterprise-contract/ec-task-bundle
TASK_VERSION ?= 0.1
TASKS ?= tasks/verify-enterprise-contract/$(TASK_VERSION)/verify-enterprise-contract.yaml tasks/verify-definition/$(TASK_VERSION)/verify-definition.yaml
TASKS ?= tasks/verify-enterprise-contract/$(TASK_VERSION)/verify-enterprise-contract.yaml
ifneq (,$(findstring localhost:,$(TASK_REPO)))
SKOPEO_ARGS=--src-tls-verify=false --dest-tls-verify=false
endif
Expand Down
2 changes: 1 addition & 1 deletion acceptance/kubernetes/kind/image.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func (k *kindCluster) buildTaskBundleImage(ctx context.Context) error {
}
for _, versionPath := range versions {
pathSplit := strings.Split(versionPath, "/")
// there should only be versions under the task path i.e. tasks/verify-definition/0.1
// there should only be versions under the task path i.e. tasks/verify-enterprise-contract/0.1
version := pathSplit[len(pathSplit)-1]
// assume the task definition file is named the same as the task directory
fileName := filepath.Join(versionPath, fmt.Sprintf("%s.yaml", taskName))
Expand Down
25 changes: 0 additions & 25 deletions docs/modules/ROOT/pages/verify-definition.adoc

This file was deleted.

1 change: 0 additions & 1 deletion docs/modules/ROOT/partials/tasks_nav.adoc
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
* xref:tasks.adoc[Tekton Tasks]
** xref:verify-definition.adoc[verify-definition]
** xref:verify-enterprise-contract.adoc[verify-enterprise-contract]
9 changes: 0 additions & 9 deletions features/__snapshots__/task_validate_definition.snap

This file was deleted.

16 changes: 0 additions & 16 deletions features/task_validate_definition.feature

This file was deleted.

50 changes: 0 additions & 50 deletions tasks/verify-definition/0.1/README.md

This file was deleted.

83 changes: 0 additions & 83 deletions tasks/verify-definition/0.1/verify-definition.yaml

This file was deleted.

0 comments on commit 6637f3d

Please sign in to comment.