Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain modal consistency with Dialog.Content component #146

Merged
merged 2 commits into from
May 23, 2024

Conversation

storywithoutend
Copy link
Contributor

Dialog

  • Set overflow:hidden, I believe this wasn't set before because in case a overflow was desired (such as the status dot on input elements), but since we don't do that I think it's better to set it to hidden so that dialogs can handle overflow more gracefully.
  • Set mobile max-height: 80vh and desktop max-height: 90vh. Mobile is smaller because we have to account for when mobile browsers display the browser header and footer even when the screen is full height.
  • Can set the fontVariant of Heading title

Dialog.Content

  • Option to be used as a form element
  • Controls sizing of Dialog.
  • Keeps consistent width in desktop mode.
  • Has option to be fullWidth of

ScrollBox

  • Broke a part the previous component into separate parts. This was because we need the overflow indicator lines to always be the width of the content area when the scrollbar is displayed and when it isn't.
  • Added alwaysShowDivider to prevent the divider from being hidden.
  • Added horizontalPadding This allows the content to have some overflow without triggering horizontal scroll. Is set at 8px by default.

Copy link

cloudflare-workers-and-pages bot commented May 15, 2024

Deploying thorin with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea10184
Status: ✅  Deploy successful!
Preview URL: https://ffee363d.thorin.pages.dev
Branch Preview URL: https://add-scrollbox-divider-always.thorin.pages.dev

View logs

@storywithoutend storywithoutend merged commit 16e673e into main May 23, 2024
4 checks passed
@storywithoutend storywithoutend deleted the add-scrollbox-divider-always-show branch May 23, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants