Merge pull request #103 from ensdomains/tooltip-version-2

add onShowCallback to Dynamic popover
ensdomains · Feb 15, 2023 · 1834985 · 1834985
2 parents e7a7ddd + 3edacc6
commit 1834985
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/components/src/components/atoms/DynamicPopover/DynamicPopover.tsx b/components/src/components/atoms/DynamicPopover/DynamicPopover.tsx
@@ -298,6 +298,7 @@ export const DynamicPopover = ({
     const handleMouseenter = () => {
       setPosition()
       toggle(true)
+      onShowCallback?.()
     }
 
     const handleMouseleave = () => {

diff --git a/components/src/components/molecules/Tooltip/Tooltip.tsx b/components/src/components/molecules/Tooltip/Tooltip.tsx
@@ -83,7 +83,6 @@ const TooltipPopoverElement = styled.div<{
     border-radius: ${theme.radii.large};
     padding: ${theme.space['2.5']} ${theme.space['2.5']} ${theme.space['2.5']}
       ${theme.space['3.5']};
-    /* border-color: ${theme.colors.border}; */
     background: ${theme.colors.background};
 
     ${injectedCss[$mobilePlacement]}

diff --git a/docs/src/reference/mdx/molecules/Tooltip.docs.mdx b/docs/src/reference/mdx/molecules/Tooltip.docs.mdx
@@ -25,6 +25,9 @@ import { Tooltip, TooltipProps } from '@ensdomains/thorin'
     placement="top"
     targetId="buttonIdTop"
     width={250}
+    onShowCallback={() => {
+      alert('shown')
+    }}
   >
     <Button
       id="buttonIdTop"