Capsule integration final #883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usecapsule-integration-two
Deploying ens-app-v3 with
|
| Latest commit: |
8521a2a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca3c9e1b.ens-app-v3.pages.dev |
| Branch Preview URL: | https://capsule-integration-final.ens-app-v3.pages.dev |
…capsule-integration-final
Default to moonpay when balance is zero
…capsule-integration-final
TateB
requested changes
Oct 24, 2024
src/components/ConnectButton.tsx
Outdated
Comment on lines
157
to
158
| const isCapsuleConnected = getIsCapsuleConnected(wagmiConfig.state) | ||
|
|
There was a problem hiding this comment.
would this be better suited to use with wagmi's useConnections?
src/components/ConnectButton.tsx
Outdated
Comment on lines
199
to
210
| isCapsuleConnected | ||
| ? { | ||
| label: t('wallet.myWallet'), | ||
| color: 'text', | ||
| icon: <WalletSVG />, | ||
| wrapper: (children: ReactNode, key: Key) => ( | ||
| <BaseLink href="https://connect.usecapsule.com/" key={key}> | ||
| {children} | ||
| </BaseLink> | ||
| ), | ||
| } | ||
| : null, |
There was a problem hiding this comment.
if you use ...[isCapsuleConnected ? [...] : []] you can avoid filtering
src/pages/_app.tsx
Outdated
|
|
||
| import '@rainbow-me/rainbowkit/styles.css' | ||
|
|
||
| // prettier-ignore-file |
|
|
||
| const rainbowKitTheme: Theme = { | ||
| ...lightTheme({ | ||
| // accentColor: thorinLightTheme.colors.accent, // requires a hex string color but thorinLightTheme returns a hsl string |
src/utils/query/capsuleWallet.ts
Outdated
Comment on lines
26
to
27
| githubUrl: 'https://github.com/ensdomains', | ||
| xUrl: 'https://twitter.com/ensdomains', |
There was a problem hiding this comment.
we have these elsewhere i think, would be nice to have a single reference
src/utils/query/capsuleWallet.ts
Outdated
| githubUrl: 'https://github.com/ensdomains', | ||
| xUrl: 'https://twitter.com/ensdomains', | ||
| homepageUrl: 'https://ens.domains/', | ||
| supportUrl: 'mailto:[email protected]', |
Comment on lines
-131
to
-150
| const isSupportedChain = (chainId: number): chainId is (typeof chains)[number]['id'] => | ||
| chains.some((c) => c.id === chainId) | ||
|
|
||
| // hotfix for wagmi bug | ||
| wagmiConfig_.subscribe( | ||
| ({ connections, current }) => (current ? connections.get(current)?.chainId : undefined), | ||
| (chainId_) => { | ||
| const chainId = chainId_ || chains[0].id | ||
| // If chain is not configured, then don't switch over to it. | ||
| const isChainConfigured = isSupportedChain(chainId) | ||
| if (!isChainConfigured) return | ||
|
|
||
| return wagmiConfig_.setState((x) => ({ | ||
| ...x, | ||
| chainId: chainId ?? x.chainId, | ||
| })) | ||
| }, | ||
| ) | ||
|
|
There was a problem hiding this comment.
we still need these unless they went somewhere else, our logic means we're always defaulting to the 0th item in the chain array (without it it'll stay on the last connected supported chain)
…capsule-integration-final
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.