Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownership PR #585

Merged
merged 21 commits into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ node_modules
# testing
/coverage
/playwright-report
/test-results

# next.js
/.next/
Expand Down Expand Up @@ -67,4 +68,4 @@ tsconfig.tsbuildinfo
# Sentry
.sentryclirc

.dev.vars
.dev.vars
1 change: 1 addition & 0 deletions deploy/00_register_legacy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
subnames,
...rest
}: Name) => {
// eslint-disable-next-line no-restricted-syntax
const secret = '0x0000000000000000000000000000000000000000000000000000000000000000'
const registrant = allNamedAccts[namedOwner]
const owner = namedController ? allNamedAccts[namedController] : undefined
Expand Down
18 changes: 9 additions & 9 deletions e2e/specs/stateful/profile.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,12 @@ const profiles = [
{
type: 'manager',
value: 'wrapmebaby.eth',
address: '0xFc5958B4B6F9a06D21E06429c8833f865577acf0',
},
{
type: 'owner',
value: 'wrapmebaby.eth',
address: '0xFc5958B4B6F9a06D21E06429c8833f865577acf0',
},
],
expiry: 'May 30, 2037',
Expand Down Expand Up @@ -208,26 +210,24 @@ test.describe('Profile', () => {
}

// should show details in more tab
await page.getByTestId('more-tab').click()

// should have correct ownership data
await page.getByTestId('ownership-tab').click()
for (const owner of profile.owners) {
await expect(page.getByTestId(`owner-button-name-name.${owner.type}`)).toContainText(
owner.value,
{ timeout: 25000 },
)
await expect(
page.getByTestId(`role-row-${owner.address}`).getByTestId(`role-tag-${owner.type}`),
).toBeVisible()
await expect(page.getByTestId(`role-row-${owner.address}`)).toContainText(owner.value)
}

// should have view link for registration transaction
await page.getByTestId('more-tab').click()
await page.getByTestId('ownership-tab').click()
await expect(page.getByTestId('etherscan-registration-link')).toHaveAttribute(
'href',
/https:\/\/goerli\.etherscan\.io\/tx\/0x[a-fA-F0-9]{64}/,
)

// should show the expiry of the name if available
if (profile.expiry) {
await expect(page.getByTestId('expiry-data')).toContainText(profile.expiry)
await expect(page.getByTestId('expiry-panel-expiry')).toContainText(profile.expiry)
}
})
}
Expand Down
Loading
Loading