コメント機能を実装しました！ #100
Merged
コメント機能を実装しました！ #100
+271
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
見栄えとか，再描画のところ直したいけど，直せないから助けて欲しい，，， |
hotsukai
reviewed
Jan 13, 2021
pages/_nodeId/_articleId.vue
Outdated
Comment on lines
163
to
165
| isNoComment() { | ||
| return this.inputComment === ""; | ||
| }, |
There was a problem hiding this comment.
これでも動くけど常に判定し続けるものはcomputedに書くのがセオリーな感じがする!!
bb9e9bc で対応しました |
|
時間がでてないからわかりづらいけど，上の方が最新になっているはず
投稿時間の取得方法がわからなかった！ |
|
ローカルでは確認してなくて、PRのpreview環境なんだけど、
|
|
|
|
|
これなんで秒まで表示されてるんだろう?? |
|
色々直した！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容
匿名のコメントを書けるようにしました！
#96 とコンフリクトするかもだけど、機能面だけ実装したから許して😅
Issue
close #64